wsry commented on a change in pull request #9993:
[FLINK-14498][runtime]Introduce NetworkBufferPool#isAvailable() for interacting
with LocalBufferPool.
URL: https://github.com/apache/flink/pull/9993#discussion_r341048184
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
##########
@@ -247,7 +247,7 @@ private MemorySegment requestMemorySegment(boolean
isBlocking) throws Interrupte
segment = availableMemorySegments.poll();
}
- if (isBlocking && isUnavailable()) {
+ if (availableMemorySegments.isEmpty()) {
Review comment:
I reserved the ```isBlocking ``` condition. Given that one local pool is
never used to serve both blocking and unblocking buffer request, there is
should be no side effect. This problem can be fixed in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
