wsry commented on a change in pull request #9993:
[FLINK-14498][runtime]Introduce NetworkBufferPool#isAvailable() for interacting
with LocalBufferPool.
URL: https://github.com/apache/flink/pull/9993#discussion_r340971659
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
##########
@@ -269,6 +267,17 @@ private MemorySegment requestMemorySegmentFromGlobal()
throws IOException {
if (segment != null) {
numberOfRequestedMemorySegments++;
return segment;
+ } else if (isBlocking) {
+ // if the future is completed before the
callback is registered,
+ // the request thread will wait 2s before
polling an available
+ // segment from the global pool, which is not a
big problem.
Review comment:
Currently, we rely on the wait to release the sync lock, so operations like
buffer recycle can acquire the log. If we replace the wait with future.get, we
need to consider how to release the sync lock properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
