pnowojski commented on a change in pull request #10029: [FLINK-14553][runtime]
Respect non-blocking output in StreamTask#processInput
URL: https://github.com/apache/flink/pull/10029#discussion_r340576311
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/AvailabilityProvider.java
##########
@@ -29,10 +29,30 @@
public interface AvailabilityProvider {
/**
* Constant that allows to avoid volatile checks {@link
CompletableFuture#isDone()}. Check
- * {@link #getAvailableFuture()} for more explanation.
+ * {@link #isAvailable()} and {@link #isVolatileAvailable()}for more
explanation.
*/
CompletableFuture<?> AVAILABLE =
CompletableFuture.completedFuture(null);
+ /**
+ * Checks whether this instance is available via constant {@link
#AVAILABLE} to avoid volatile access.
+ *
+ * @return true if this instance is available for further processing.
+ */
+ default boolean isAvailable() {
Review comment:
I would squash them, otherwise the 1st commit was confusing me (please see
the comments that I scratched out when I was doing the first pass of reviewing)
and it also makes the reviewing more difficult (I would still like to look at
those two changes combined, to see all of the `isAvailable()` ->
`getAvailableFuture()` affected changes in one place/commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
