pnowojski commented on a change in pull request #10029: [FLINK-14553][runtime]
Respect non-blocking output in StreamTask#processInput
URL: https://github.com/apache/flink/pull/10029#discussion_r340018181
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
##########
@@ -35,23 +35,23 @@
* In this case {@link ResultPartitionWriter#fail(Throwable)} still needs to
be called afterwards to fully release
* all resources associated the the partition and propagate failure cause to
the consumer if possible.
*/
-public interface ResultPartitionWriter extends AutoCloseable {
+public abstract class ResultPartitionWriter implements AutoCloseable,
AvailabilityProvider {
Review comment:
What limitation do you mean by:
> The current ResultPartitionWriter interface already extends AutoCloseable,
so it has the limitation to further extend any other interfaces.
Also I do not understand this commit. Could you explain why abstract class
is better than an interface in this case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
