pnowojski commented on a change in pull request #10029: [FLINK-14553][runtime]
Respect non-blocking output in StreamTask#processInput
URL: https://github.com/apache/flink/pull/10029#discussion_r340041508
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionFactory.java
##########
@@ -187,7 +197,8 @@ private static void
releasePartitionsQuietly(ResultSubpartition[] partitions, in
numberOfSubpartitions *
networkBuffersPerChannel + floatingNetworkBuffersPerGate : Integer.MAX_VALUE;
// If the partition type is back pressure-free, we
register with the buffer pool for
// callbacks to release memory.
- return
bufferPoolFactory.createBufferPool(numberOfSubpartitions,
+ return bufferPoolFactory.createBufferPool(
+ numberOfSubpartitions + 1,
Review comment:
I think this needs to be squashed with the previous commit as again, those
two things are heavily interconnected and on their own they are
incomplete/missing context.
Also, can we add a test for that? That `StreamTask` is able to make a
non-blocking progress with a minimal `LocalBufferPool`? Or is it already
covered by some existing tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
