zentol commented on a change in pull request #10034: [FLINK-14400] Shrink scope
of MemoryManager from TaskExecutor to slot
URL: https://github.com/apache/flink/pull/10034#discussion_r341066870
##########
File path:
flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/aggregate/BytesHashMapTest.java
##########
@@ -98,7 +98,6 @@ public void testHashSetMode() throws IOException {
MemoryManager memoryManager = MemoryManagerBuilder
.newBuilder()
.setMemorySize(numMemSegments * PAGE_SIZE)
- .setNumberOfSlots(32)
Review comment:
I would merge this commit with the one removing the numberOfSlots argument.
Makes it much clearer that this commit does affect behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
