zentol commented on a change in pull request #10034: [FLINK-14400] Shrink scope
of MemoryManager from TaskExecutor to slot
URL: https://github.com/apache/flink/pull/10034#discussion_r341179474
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -258,15 +253,15 @@ public static TaskManagerServices fromConfiguration(
taskManagerServicesConfiguration.getTaskManagerAddress(),
dataPort);
- // this call has to happen strictly after the network stack has
been initialized
- final MemoryManager memoryManager =
createMemoryManager(taskManagerServicesConfiguration);
-
final BroadcastVariableManager broadcastVariableManager = new
BroadcastVariableManager();
+ // this call has to happen strictly after the network stack has
been initialized
Review comment:
let's clarify this comment; it is difficult to pinpoint which statement it
applies to, since the MemoryManager is created 2 levels into the _next_ line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
