zentol commented on a change in pull request #10034: [FLINK-14400] Shrink scope of MemoryManager from TaskExecutor to slot URL: https://github.com/apache/flink/pull/10034#discussion_r341172664
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotAndTableFactory.java ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.taskexecutor.slot; + +import org.apache.flink.api.common.time.Time; +import org.apache.flink.configuration.MemorySize; +import org.apache.flink.runtime.clusterframework.types.AllocationID; +import org.apache.flink.runtime.clusterframework.types.ResourceProfile; +import org.apache.flink.runtime.memory.MemoryManager; +import org.apache.flink.runtime.testingUtils.TestingUtils; + +import java.util.Collections; +import java.util.List; + +/** Factory for {@link TaskSlotTable} and {@link TaskSlot}s. */ +public enum TaskSlotAndTableFactory { + ; + + private static final long DEFAULT_SLOT_TIMEOUT = 10000L; + + private static final ResourceProfile DEFAULT_RESOURCE_PROFILE = + new ResourceProfile( + Double.MAX_VALUE, + MemorySize.MAX_VALUE, + MemorySize.MAX_VALUE, + new MemorySize(10 * MemoryManager.MIN_PAGE_SIZE), + new MemorySize(0), + MemorySize.MAX_VALUE, + Collections.emptyMap()); + + public static TaskSlotTable createTaskSlotTableWithDefaultSlots(int numberOfSlots) { Review comment: I'd just call this `createTaskSlotTable`; that the table will contain _some_ kind of slot is a given anyway ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
