tillrohrmann commented on a change in pull request #10076:
[FLINK-14465][runtime] Let `StandaloneJobClusterEntrypoint` use user code class
loader
URL: https://github.com/apache/flink/pull/10076#discussion_r342051053
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/ClassPathJobGraphRetriever.java
##########
@@ -133,9 +138,18 @@ private String getJobClassNameOrScanClassPath() throws
FlinkException {
}
private String scanClassPathForJobJar() throws IOException {
- LOG.info("Scanning class path for job JAR");
- JarFileWithEntryClass jobJar =
JarManifestParser.findOnlyEntryClass(jarsOnClassPath.get());
-
+ final JarFileWithEntryClass jobJar;
+ if (getUserClassPaths().isEmpty()) {
+ LOG.info("Scanning system class path for job JAR");
+ jobJar =
JarManifestParser.findOnlyEntryClass(jarsOnClassPath.get());
+ } else {
+ LOG.info("Scanning user class path for job JAR");
+ final List<File> userJars = getUserClassPaths()
+ .stream()
+ .map(url -> new File(url.getFile()))
+ .collect(Collectors.toList());
+ jobJar = JarManifestParser.findOnlyEntryClass(userJars);
+ }
Review comment:
Instead of making it an `if-else` decision could we first look into the
`getUserClassPaths` for the job jar and then
if none was found on the system class path via `jarsOnClassPath`? We might
wanna change `JarManifestParser.findOnlyEntryClass` to return an `Optional`
instead of failing with a `NoSuchElementException`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
