tillrohrmann commented on a change in pull request #10076: 
[FLINK-14465][runtime] Let `StandaloneJobClusterEntrypoint` use user code class 
loader
URL: https://github.com/apache/flink/pull/10076#discussion_r342060784
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
 ##########
 @@ -2021,6 +2021,9 @@
        /** The environment variable name which contains the Flink installation 
root directory. */
        public static final String ENV_FLINK_HOME_DIR = "FLINK_HOME";
 
+       /** The default job directory name in the per-job mode. */
+       public static final String DEFAULT_JOB_DIRECTORY_NAME = "job";
 
 Review comment:
   Shall we call this `usrlib` instead of `job`? It would mean that this is 
similar to `lib` just that it will be loaded by the user code classloader. 
Similarly `DEFAULT_JOB_DIRECTORY_NAME` should then be renamed into 
`DEFAULT_FLINK_USR_LIB_DIR`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to