tillrohrmann commented on a change in pull request #10076:
[FLINK-14465][runtime] Let `StandaloneJobClusterEntrypoint` use user code class
loader
URL: https://github.com/apache/flink/pull/10076#discussion_r342044766
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgram.java
##########
@@ -184,8 +184,6 @@ public PackagedProgram(File jarFile, List<URL> classpaths,
@Nullable String entr
}
checkJarFile(jarFileUrl);
- } else if (!isPython) {
- throw new IllegalArgumentException("The jar file must
not be null.");
Review comment:
I think we should actually rework how this class is constructed. There are
now some combinations possible which don't make sense. E.g. setting `jarFile ==
null` and `entryPointClassName == null`. If this is the case, then one cannot
generate the `JobGraph`. Hence, I would suggest that we hide this behind some
static factory methods/builder which only accept a valid combination of
parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
