tillrohrmann commented on a change in pull request #10076: 
[FLINK-14465][runtime] Let `StandaloneJobClusterEntrypoint` use user code class 
loader
URL: https://github.com/apache/flink/pull/10076#discussion_r342055681
 
 

 ##########
 File path: 
flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterEntryPoint.java
 ##########
 @@ -74,10 +79,20 @@ private StandaloneJobClusterEntryPoint(
        }
 
        @Override
-       protected DispatcherResourceManagerComponentFactory 
createDispatcherResourceManagerComponentFactory(Configuration configuration) {
+       protected DispatcherResourceManagerComponentFactory 
createDispatcherResourceManagerComponentFactory(Configuration configuration) 
throws IOException {
+               final String flinkHomeDir = System.getenv(ENV_FLINK_HOME_DIR);
 
 Review comment:
   I'm not sure that you can do this. Afaik we don't export `FLINK_HOME`. Have 
you verified that this ENV variable will be set if you start a Flink process?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to