tillrohrmann commented on a change in pull request #10076: 
[FLINK-14465][runtime] Let `StandaloneJobClusterEntrypoint` use user code class 
loader
URL: https://github.com/apache/flink/pull/10076#discussion_r342471972
 
 

 ##########
 File path: 
flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgram.java
 ##########
 @@ -184,8 +184,6 @@ public PackagedProgram(File jarFile, List<URL> classpaths, 
@Nullable String entr
                        }
 
                        checkJarFile(jarFileUrl);
-               } else if (!isPython) {
-                       throw new IllegalArgumentException("The jar file must 
not be null.");
 
 Review comment:
   Yeah, we can do this as a follow up but then we need to add this check as 
@zhuzhurk suggested. On the other hand, I think this change would not be 
terribly big.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to