tillrohrmann commented on a change in pull request #10076:
[FLINK-14465][runtime] Let `StandaloneJobClusterEntrypoint` use user code class
loader
URL: https://github.com/apache/flink/pull/10076#discussion_r342477518
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterEntryPoint.java
##########
@@ -74,10 +79,20 @@ private StandaloneJobClusterEntryPoint(
}
@Override
- protected DispatcherResourceManagerComponentFactory
createDispatcherResourceManagerComponentFactory(Configuration configuration) {
+ protected DispatcherResourceManagerComponentFactory
createDispatcherResourceManagerComponentFactory(Configuration configuration)
throws IOException {
+ final String flinkHomeDir = System.getenv(ENV_FLINK_HOME_DIR);
Review comment:
I think it works in Docker because the Dockerfile defines `FLINK_HOME` as an
env variable. The problem is that the other scripts like `flink-daemon.sh`
don't do this.
Not sure whether the working directory will work because image people
started the cluster from within `FLINK_HOME/bin`.
What do you mean with "We could try the `ENV_FLINK_USR_LIB_DIR` directory
first"?
I'm wondering whether introducing a new env variable for every directory is
a good practice. Instead one could derive directories like `lib`, `conf`,
`plugins`, `usrlib` if `FLINK_HOME` would be defined. So maybe the right
approach would be to update the entrypoints to properly set this env variable
and derive the other directories relative to this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
