rkhachatryan commented on a change in pull request #10345:
[FLINK-12484][runtime] synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345#discussion_r352369808
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/MailboxProcessor.java
##########
@@ -152,7 +160,7 @@ public void runMailboxLoop() throws Exception {
final MailboxController defaultActionContext = new
MailboxController(this);
while (processMail(localMailbox)) {
-
mailboxDefaultAction.runDefaultAction(defaultActionContext);
+
mailboxDefaultAction.runDefaultAction(defaultActionContext); // currently, lock
is acquired inside each action
Review comment:
Probably, I misworded the comment (updated).
The lock is acquired inside `default action` as needed, not in a uniform
fashion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
