azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r351880023
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceSpec.java
##########
@@ -78,6 +81,8 @@
*/
public class TaskExecutorResourceSpec implements Serializable {
+ private final Optional<CPUResource> cpuCores;
Review comment:
according to the Flink code style, we agreed to use `Optional` only to
return values from public methods. The private class fields should be
`@Nullable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
