azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352228283
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
##########
@@ -242,10 +263,15 @@ public boolean allocateSlot(int index, JobID jobId,
AllocationID allocationId, T
return false;
}
+ ResourceProfile slotResourceProfile =
defaultSlotResourceProfile;
+ if (!resourceProfileBookkeeper.reserve(slotResourceProfile)) {
+ return false;
Review comment:
would be nice to log how much we tried to allocate and what was available
budget in case of failure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
