azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352216048
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
##########
@@ -205,10 +221,11 @@ public SlotReport createSlotReport(ResourceID
resourceId) {
// ---------------------------------------------------------------------
/**
- * Allocate the slot with the given index for the given job and
allocation id. Returns true if
- * the slot could be allocated. Otherwise it returns false.
+ * Allocate the slot with the given index for the given job and
allocation id. If negative index is
+ * given, a new auto increasing index will be generated. Returns true
if the slot could be allocated.
Review comment:
Do we actually still need indexing by index of slots in TM?
Would it be enough to keep only indexing by `AllocationID`?
It seems the index is currently needed only in legacy RM to statically
identify free slots in the report. The current implementation of slot report
creation looks compatible with the legacy RM. Dynamic slots could just stay
with negative index and added to the report as now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
