azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352200275
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotUtils.java
##########
@@ -62,17 +59,21 @@ public static TaskSlotTable createTaskSlotTable(int
numberOfSlots, Time timeout)
private static TaskSlotTable createTaskSlotTable(
int numberOfSlots,
TimerService<AllocationID> timerService) {
- return new TaskSlotTable(createDefaultSlots(numberOfSlots),
timerService);
+ return new TaskSlotTable(numberOfSlots,
+ createDefaultSlotResourceProfile(),
+ createDefaultMemoryPageSize(),
+ timerService);
}
- public static TimerService<AllocationID> createDefaultTimerService(long
shutdownTimeout) {
- return new TimerService<>(TestingUtils.defaultExecutor(),
shutdownTimeout);
+ public static ResourceProfile createDefaultSlotResourceProfile() {
+ return DEFAULT_RESOURCE_PROFILE;
Review comment:
why do we need `createDefaultSlotResourceProfile` and
`createDefaultMemoryPageSize`? why not just use `DEFAULT_RESOURCE_PROFILE` and
`MemoryManager.MIN_PAGE_SIZE`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
