azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352208816
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotID.java
##########
@@ -32,6 +32,13 @@
*/
public class SlotID implements ResourceIDRetrievable, Serializable {
+ /**
+ * Generate a SlotID without actual slot index for dynamic slot
allocation.
+ */
+ public static SlotID generateDynamicSlotID(ResourceID resourceID) {
Review comment:
we usually put static methods at the end
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
