zhijiangW commented on a change in pull request #10347: [FLINK-14516][network]
Remove non credit-based flow control code
URL: https://github.com/apache/flink/pull/10347#discussion_r352413463
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironmentTest.java
##########
@@ -184,17 +158,17 @@ private void testRegisterTaskWithLimitedBuffers(int
bufferPoolSize) throws Excep
// verify buffer pools for the input gates (NOTE: credit-based
uses minimum required buffers
// for exclusive buffers not managed by the buffer pool)
- assertEquals(enableCreditBasedFlowControl ? 0 : channels,
ig1.getBufferPool().getNumberOfRequiredMemorySegments());
- assertEquals(enableCreditBasedFlowControl ? 0 : channels,
ig2.getBufferPool().getNumberOfRequiredMemorySegments());
- assertEquals(enableCreditBasedFlowControl ? 0 : channels,
ig3.getBufferPool().getNumberOfRequiredMemorySegments());
- assertEquals(enableCreditBasedFlowControl ? 0 : rp4Channels,
ig4.getBufferPool().getNumberOfRequiredMemorySegments());
+ assertEquals(0,
ig1.getBufferPool().getNumberOfRequiredMemorySegments());
+ assertEquals(0,
ig2.getBufferPool().getNumberOfRequiredMemorySegments());
+ assertEquals(0,
ig3.getBufferPool().getNumberOfRequiredMemorySegments());
+ assertEquals(0,
ig4.getBufferPool().getNumberOfRequiredMemorySegments());
assertEquals(Integer.MAX_VALUE,
ig1.getBufferPool().getMaxNumberOfMemorySegments());
assertEquals(Integer.MAX_VALUE,
ig2.getBufferPool().getMaxNumberOfMemorySegments());
- assertEquals(enableCreditBasedFlowControl ? floatingBuffers :
expectedBuffers, ig3.getBufferPool().getMaxNumberOfMemorySegments());
- assertEquals(enableCreditBasedFlowControl ? floatingBuffers :
expectedRp4Buffers, ig4.getBufferPool().getMaxNumberOfMemorySegments());
+ assertEquals(floatingBuffers,
ig3.getBufferPool().getMaxNumberOfMemorySegments());
+ assertEquals(floatingBuffers,
ig4.getBufferPool().getMaxNumberOfMemorySegments());
- int invokations = enableCreditBasedFlowControl ? 1 : 0;
+ int invokations = true ? 1 : 0;
Review comment:
nit: `int invokations = 1` directly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
