zhijiangW commented on a change in pull request #10347: [FLINK-14516][network]
Remove non credit-based flow control code
URL: https://github.com/apache/flink/pull/10347#discussion_r352443161
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/NettyShuffleMetricFactory.java
##########
@@ -180,18 +176,14 @@ private static void registerInputMetrics(
buffersGroup.gauge(METRIC_INPUT_QUEUE_LENGTH, new
InputBuffersGauge(inputGates));
- if (isCreditBased) {
- FloatingBuffersUsageGauge floatingBuffersUsageGauge =
new FloatingBuffersUsageGauge(inputGates);
- ExclusiveBuffersUsageGauge exclusiveBuffersUsageGauge =
new ExclusiveBuffersUsageGauge(inputGates);
- CreditBasedInputBuffersUsageGauge
creditBasedInputBuffersUsageGauge = new CreditBasedInputBuffersUsageGauge(
- floatingBuffersUsageGauge,
- exclusiveBuffersUsageGauge,
- inputGates);
-
buffersGroup.gauge(METRIC_INPUT_EXCLUSIVE_BUFFERS_USAGE,
exclusiveBuffersUsageGauge);
- buffersGroup.gauge(METRIC_INPUT_FLOATING_BUFFERS_USAGE,
floatingBuffersUsageGauge);
- buffersGroup.gauge(METRIC_INPUT_POOL_USAGE,
creditBasedInputBuffersUsageGauge);
- } else {
- buffersGroup.gauge(METRIC_INPUT_POOL_USAGE, new
InputBufferPoolUsageGauge(inputGates));
Review comment:
also remove `InputBufferPoolUsageGauge` class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
