zhijiangW commented on a change in pull request #10347: [FLINK-14516][network]
Remove non credit-based flow control code
URL: https://github.com/apache/flink/pull/10347#discussion_r352439583
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CachedBufferStorage.java
##########
@@ -74,49 +102,139 @@ public void add(BufferOrEvent boe) {
}
/**
- * It is never reusing resources and is defaulting to {@link
#rollOverWithoutReusingResources()}.
+ * Starts a new sequence of buffers and event reusing the same
resources and
+ * returns the current sequence of buffers for reading.
+ *
+ * @return The readable sequence of buffers and events, or 'null', if
nothing was added.
*/
- @Override
public BufferOrEventSequence rollOverReusingResources() {
Review comment:
It is no need to distinguish `rollOverReusingResources` and
`rollOverWithoutReusingResources` if we only have `CachedBufferStorage`? If so
we can retain only one method, also for private method instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
