zhijiangW commented on a change in pull request #10347: [FLINK-14516][network]
Remove non credit-based flow control code
URL: https://github.com/apache/flink/pull/10347#discussion_r352437741
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CachedBufferStorage.java
##########
@@ -35,11 +40,31 @@
* alignment in exactly-once mode.
*/
@Internal
-public class CachedBufferStorage extends AbstractBufferStorage {
+public class CachedBufferStorage implements BufferStorage {
+ private static final Logger LOG =
LoggerFactory.getLogger(CachedBufferStorage.class);
+
+ /**
+ * The pending blocked buffer/event sequences. Must be consumed before
requesting further data
+ * from the input gate.
+ */
+ protected final ArrayDeque<BufferOrEventSequence> queuedBuffered = new
ArrayDeque<>();
Review comment:
can be private, also for the other following variables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
