zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime] 
Introduce data compression to reduce disk and network IO of shuffle.
URL: https://github.com/apache/flink/pull/10375#discussion_r353706812
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/PartitionTestUtils.java
 ##########
 @@ -58,6 +58,21 @@ public static ResultPartition 
createPartition(ResultPartitionType type, FileChan
                        .build();
        }
 
+       public static ResultPartition createPartition(
+                       ResultPartitionType type,
+                       FileChannelManager channelManager,
+                       boolean compressEnabled,
+                       String  compressCodec,
 
 Review comment:
   This parameter might be not needed because we always have only one codec for 
compression.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to