zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime]
Introduce data compression to reduce disk and network IO of shuffle.
URL: https://github.com/apache/flink/pull/10375#discussion_r354095399
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyMessageSerializationTest.java
##########
@@ -135,14 +148,17 @@ public void testEncodeDecode() {
}
}
- private void testEncodeDecodeBuffer(boolean testReadOnlyBuffer) {
- NetworkBuffer buffer = new
NetworkBuffer(MemorySegmentFactory.allocateUnpooledSegment(1024),
FreeingBufferRecycler.INSTANCE);
+ private void testEncodeDecodeBuffer(boolean testReadOnlyBuffer, boolean
testCompressedBuffer) {
+ NetworkBuffer buffer = new
NetworkBuffer(MemorySegmentFactory.allocateUnpooledSegment(BUFFER_SIZE),
FreeingBufferRecycler.INSTANCE);
- for (int i = 0; i < 1024; i += 4) {
- buffer.writeInt(i);
+ for (int i = 0; i < BUFFER_SIZE; i += 8) {
+ buffer.writeLong(i);
Review comment:
Are there any considerations for changing to `Long` instead of previous
`Int`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
