zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime]
Introduce data compression to reduce disk and network IO of shuffle.
URL: https://github.com/apache/flink/pull/10375#discussion_r354094379
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandlerTest.java
##########
@@ -161,11 +165,42 @@ public void testReceiveBuffer() throws Exception {
assertEquals(1,
inputChannel.getNumberOfQueuedBuffers());
assertEquals(2, inputChannel.getSenderBacklog());
} finally {
- // Release all the buffer resources
- inputGate.close();
+ releaseResource(inputGate, networkBufferPool);
Review comment:
The previous tests refactoring can be done as a separate hotfix commit if
you like, also for other similar places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
