zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime]
Introduce data compression to reduce disk and network IO of shuffle.
URL: https://github.com/apache/flink/pull/10375#discussion_r353709213
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionWithReadViewTest.java
##########
@@ -62,7 +64,8 @@
@Before
public void setup() throws IOException {
- final ResultPartition parent = mock(ResultPartition.class);
+ final ResultPartition parent =
PartitionTestUtils.createPartition(
+ ResultPartitionType.PIPELINED,
NoOpFileChannelManager.INSTANCE, true, "LZ4", BUFFER_SIZE);
Review comment:
Maybe it is better to make `isCompressed` as parameter, so all the previous
existing tests can verify both cases?
Also nit for separate line with every argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
