azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r353842306
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -247,16 +247,17 @@ public static TaskManagerServices fromConfiguration(
final BroadcastVariableManager broadcastVariableManager = new
BroadcastVariableManager();
final TaskSlotTable taskSlotTable = createTaskSlotTable(
- taskManagerServicesConfiguration.getNumberOfSlots(),
-
taskManagerServicesConfiguration.getManagedMemorySize().getBytes(),
+
taskManagerServicesConfiguration.getTaskExecutorResourceSpec(),
taskManagerServicesConfiguration.getTimerServiceShutdownTimeout(),
taskManagerServicesConfiguration.getPageSize());
final JobManagerTable jobManagerTable = new JobManagerTable();
- final JobLeaderService jobLeaderService = new
JobLeaderService(taskManagerLocation,
taskManagerServicesConfiguration.getRetryingRegistrationConfiguration());
+ final JobLeaderService jobLeaderService = new
JobLeaderService(taskManagerLocation,
+
taskManagerServicesConfiguration.getRetryingRegistrationConfiguration());
Review comment:
unrelated changes, also right afterwards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
