azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r353841985
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -212,15 +212,15 @@ public void shutDown() throws FlinkException {
* Creates and returns the task manager services.
*
* @param taskManagerServicesConfiguration task manager configuration
- * @param taskManagerMetricGroup metric group of the task manager
- * @param taskIOExecutor executor for async IO operations
+ * @param taskManagerMetricGroup metric group of the task
manager
+ * @param taskIOExecutor executor for async IO
operations
* @return task manager components
* @throws Exception
*/
public static TaskManagerServices fromConfiguration(
- TaskManagerServicesConfiguration
taskManagerServicesConfiguration,
- MetricGroup taskManagerMetricGroup,
- Executor taskIOExecutor) throws Exception {
+ TaskManagerServicesConfiguration
taskManagerServicesConfiguration,
Review comment:
formatting is off
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
