azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r353842612
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -284,31 +285,29 @@ public static TaskManagerServices fromConfiguration(
}
private static TaskSlotTable createTaskSlotTable(
- final int numberOfSlots,
- final long managedMemorySize,
- final long timerServiceShutdownTimeout,
- final int pageSize) {
- final List<ResourceProfile> resourceProfiles =
- Collections.nCopies(numberOfSlots,
computeSlotResourceProfile(numberOfSlots, managedMemorySize));
+ final TaskExecutorResourceSpec taskExecutorResourceSpec,
Review comment:
formatting is off, also further down for some other functions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
