azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r353848115
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -103,6 +105,12 @@ public static ResourceProfile
generateDefaultSlotResourceProfile(TaskExecutorRes
.build();
}
+ public static List<ResourceProfile>
createWorkerSlotProfiles(TaskExecutorResourceSpec taskExecutorResourceSpec) {
Review comment:
code style nit: better to put this function before
`generateDefaultSlotResourceProfile`
we usually put functions used in other functions after them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
