zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime]
Introduce data compression to reduce disk and network IO of shuffle.
URL: https://github.com/apache/flink/pull/10375#discussion_r354098302
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyMessageSerializationTest.java
##########
@@ -51,8 +62,10 @@
@Test
public void testEncodeDecode() {
- testEncodeDecodeBuffer(false);
- testEncodeDecodeBuffer(true);
+ testEncodeDecodeBuffer(false, false);
+ testEncodeDecodeBuffer(true, false);
+ testEncodeDecodeBuffer(false, true);
+ testEncodeDecodeBuffer(true, true);
Review comment:
It might be better to refactor it via @Parameters way instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
