tillrohrmann commented on a change in pull request #10921: [FLINK-15692][state
backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10921#discussion_r369585868
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
##########
@@ -139,11 +142,25 @@
@Rule
public final ExpectedException expectedException =
ExpectedException.none();
+ @Before
+ public void before() {
+ env = buildMockEnv();
+ }
+
+ @After
+ public void after() {
+ IOUtils.closeQuietly(env);
+ }
+
// lazily initialized stream storage
private CheckpointStreamFactory checkpointStreamFactory;
+ private MockEnvironment env;
+
protected abstract B getStateBackend() throws Exception;
+ protected abstract long getManagedMemorySize();
Review comment:
Same here with the `getManagedMemorySize`. With the above propose solution
we would only need to override this method for RocksDB related classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
