tillrohrmann commented on a change in pull request #10921: [FLINK-15692][state
backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10921#discussion_r369661246
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendMigrationTestBase.java
##########
@@ -71,12 +74,26 @@
protected abstract B getStateBackend() throws Exception;
+ protected abstract long getManagedMemorySize();
Review comment:
Ah I understand now. You actually want to not give managed memory to all
state backend tests which don't need it. If we want to make sure that these
tests actually work without `MemorySegments`, I can see the benefit of
disabling managed memory for them. Maybe we could then do it the other way
around meaning that we only explicitly deactivate/set managed memory to `0` for
those tests but by default the `MockEnvironmentBuilder` gives you 32 MB of
managed memory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
