Myasuka commented on a change in pull request #10921: [FLINK-15692][state
backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10921#discussion_r369686491
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendMigrationTestBase.java
##########
@@ -71,12 +74,26 @@
protected abstract B getStateBackend() throws Exception;
+ protected abstract long getManagedMemorySize();
Review comment:
Previously, memory manager for test would reserve on-heap memory by default.
However, after
[FLINK-15023](https://issues.apache.org/jira/browse/FLINK-15023), on-heap
memory is not managed anymore.
As I talked with @xintongsong offline, the reason did not remove on-heap
memory from memory manager for testing is mainly due to the consideration for
tests could be finished more quickly if we only allocate on-heap memory for
testing.
In this PR, we enable rocksDB to use managed memory by default. And I'll
correct those places not setting off-heap managed memory. This might lead to
some places which not need off-heap also reserved off-heap memory.
However, I found too many places to cut that redundant off-heap memory to
polish the tests to the best situation and a bit out of scope of this PR
targets. After I think about it for a while, I prefer to let the part to remove
unnecessary off-heap memory for testing as another story or issue but not
included in this PR. If so, I'll not call to set managed memory as `0` in these
mem state backends.
What do you think of this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
