tillrohrmann commented on a change in pull request #10921: [FLINK-15692][state
backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10921#discussion_r369585131
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendMigrationTestBase.java
##########
@@ -71,12 +74,26 @@
protected abstract B getStateBackend() throws Exception;
+ protected abstract long getManagedMemorySize();
Review comment:
I don't really like that we introduce this method for all sub classes of
this class. Instead, it should only be relevant for RocksDB related tests. One
alternative would be to introcude
```
protected void modifyMockEnvironmentBuilder(MockEnvironmentBuilder builder)
{}
```
which we call in `before()` and which can be overriden by the RocksDB tests
to set the managed memory size. That way, all non RocksDB related test classes
would not need to implement this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
