Myasuka commented on a change in pull request #10921: [FLINK-15692][state
backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10921#discussion_r369718225
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendMigrationTestBase.java
##########
@@ -71,12 +74,26 @@
protected abstract B getStateBackend() throws Exception;
+ protected abstract long getManagedMemorySize();
Review comment:
@StephanEwen I think @xintongsong might give some explanations here.
If the configured off-heap memory would not hurt, my approach works.
If the configured off-heap has a bit impact, my approach should still be
picked to let flowing-up commits to fix.
In a nut shell, I'll update this with my approach before I go to sleep
tonight.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
