TisonKun commented on a change in pull request #10980:
[FLINK-12343][flink-yarn] add yarn file replication configuration
URL: https://github.com/apache/flink/pull/10980#discussion_r373784845
##########
File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java
##########
@@ -122,6 +136,32 @@ private void
deployPerjob(YarnConfigOptions.UserJarInclusion userJarInclusion, J
assertThat(jobResult, is(notNullValue()));
assertThat(jobResult.getSerializedThrowable().isPresent(), is(false));
+ if
(configuration.getInteger(YarnConfigOptions.FILE_REPLICATION) != -1) {
Review comment:
Could you please add a new test case instead of modify current test cases? I
think this pull request adds a new feature instead of code refactoring so that
we should not touch any current test cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
