HuangZhenQiu commented on a change in pull request #10980: 
[FLINK-12343][flink-yarn] add yarn file replication configuration
URL: https://github.com/apache/flink/pull/10980#discussion_r373913066
 
 

 ##########
 File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java
 ##########
 @@ -122,6 +136,32 @@ private void 
deployPerjob(YarnConfigOptions.UserJarInclusion userJarInclusion, J
                                assertThat(jobResult, is(notNullValue()));
                                
assertThat(jobResult.getSerializedThrowable().isPresent(), is(false));
 
+                               if 
(configuration.getInteger(YarnConfigOptions.FILE_REPLICATION) != -1) {
 
 Review comment:
   Agree. I actually added two more test cases in YarnITCase. The change on 
this function is to minimize duplicated code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to