TisonKun commented on a change in pull request #10980:
[FLINK-12343][flink-yarn] add yarn file replication configuration
URL: https://github.com/apache/flink/pull/10980#discussion_r373784779
##########
File path:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java
##########
@@ -592,14 +608,14 @@ protected ApplicationReport getOnlyApplicationReport()
throws IOException, YarnE
}
public static void startYARNSecureMode(YarnConfiguration conf, String
principal, String keytab) {
- start(conf, principal, keytab);
+ start(conf, principal, keytab, false);
}
- public static void startYARNWithConfig(YarnConfiguration conf) {
- start(conf, null, null);
+ public static void startYARNWithConfig(YarnConfiguration conf, boolean
withDFS) {
+ start(conf, null, null, withDFS);
}
- private static void start(YarnConfiguration conf, String principal,
String keytab) {
+ private static void start(YarnConfiguration conf, String principal,
String keytab, boolean withDFS) {
Review comment:
Could you instead use an external configuration code than such boolean flag?
Or at least use an overload method so that we don't modify all of these method
calls which only pass `withDFS == false`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
