walterddr commented on a change in pull request #10980:
[FLINK-12343][flink-yarn] add yarn file replication configuration
URL: https://github.com/apache/flink/pull/10980#discussion_r373809209
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -682,6 +683,9 @@ private ApplicationReport startAppMaster(
// add user code jars from the provided JobGraph
: jobGraph.getUserJars().stream().map(f ->
f.toUri()).map(File::new).collect(Collectors.toSet());
+ int fileReplication =
yarnConfiguration.getInt(DFSConfigKeys.DFS_REPLICATION_KEY,
DFSConfigKeys.DFS_REPLICATION_DEFAULT);
+ fileReplication =
flinkConfiguration.getInteger(YarnConfigOptions.FILE_REPLICATION,
fileReplication);
Review comment:
I think we need a test with configuration setting to `-1` (we currently only
have one test to set to `4`)
my gut feeling is that this won't work - Configuration.getInteger only
applies default value when the config key is `null`, however the default value
according to the documentation is `-1` not `null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
