pnowojski commented on a change in pull request #11155:
[FLINK-14818][benchmark] Fix receiving InputGate setup of
StreamNetworkBenchmarkEnvironment.
URL: https://github.com/apache/flink/pull/11155#discussion_r382441933
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -95,7 +95,7 @@ public LocalInputChannel(
//
------------------------------------------------------------------------
Review comment:
Please copy PR description into the commit message and once you have some
expected benchmark results, please include them in the commit message as well
:)
Could you also explain in both places, how are you solving the problem?
Maybe something along those lines:
> Before this change, in network benchmark (for example 1000 channels
benchmark with 4 record writers)
StreamNetworkBenchmarkEnvironment#createInputGate was creating 1000 input gates
with 4 input channels each, which doesn't make much sense. This commit is
changing that to a single receiver with 4 input gates, with 1000 channels each.
>
> It is achieved by providing testing implementations of InputChannels,
which are using channel index for requesting subpartitions from
ResultPartition, instead of subpartition index. Thanks to that, we can connect
single ResultPartition with N subpartitions, to a single instance of InputGate
with 1000 channels.
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
