zhijiangW commented on a change in pull request #11155:
[FLINK-14818][benchmark] Fix receiving InputGate setup of
StreamNetworkBenchmarkEnvironment.
URL: https://github.com/apache/flink/pull/11155#discussion_r383081286
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java
##########
@@ -158,6 +157,10 @@ public void tearDown() {
suppressExceptions(receiverEnv::close);
}
+ /**
+ * Note: It should be guaranteed that {@link
#createResultPartitionWriter(int)} has been called before
+ * creating the receiver.
Review comment:
nit: might supplement the reason why we should guarantee this.
E.g. `Otherwise it might cause unexpected behaviors when {@link
PartitionNotFoundException} happens in {@link TestRemoteInputChannel}`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
