wuchong commented on a change in pull request #11340: [Flink 14338] Upgrade
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r393490763
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/logical/FlinkLogicalCalc.scala
##########
@@ -39,15 +42,19 @@ import java.util.function.Supplier
class FlinkLogicalCalc(
cluster: RelOptCluster,
traitSet: RelTraitSet,
+ hints: JList[RelHint],
Review comment:
Personally, I prefer not expose hints for now. I guess all the hints are
empty list, right? Even if we pass in a RelHint, I guess it also doesn't work
because we don't have any logic around hints.
We should avoid partial work, otherwise, it will confuse and surprise users
(developers).
Then I would suggest to use empty list in `CommonCalc` , and not expose this
parameter for `FlinkLogicalCalc`, and of course for other logical RelNodes.
We can introduce hints feature as a whole in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
