wuchong commented on a change in pull request #11340: [Flink 14338] Upgrade
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r393515629
##########
File path: flink-table/flink-table-planner-blink/pom.xml
##########
@@ -39,30 +39,19 @@ under the License.
<packaging>jar</packaging>
- <dependencyManagement>
- <dependencies>
- <!-- Common dependency of calcite-core and flink-* -->
- <dependency>
- <groupId>com.google.guava</groupId>
- <artifactId>guava</artifactId>
- <version>19.0</version>
- </dependency>
- <!-- Common dependency of calcite-core and
flink-table-runtime-blink -->
- <dependency>
- <groupId>org.codehaus.janino</groupId>
- <artifactId>commons-compiler</artifactId>
- <version>${janino.version}</version>
- </dependency>
- <!-- Common dependency of calcite-core and
flink-table-runtime-blink -->
- <dependency>
- <groupId>org.codehaus.janino</groupId>
- <artifactId>janino</artifactId>
- <version>${janino.version}</version>
- </dependency>
- </dependencies>
- </dependencyManagement>
-
<dependencies>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.codehaus.janino</groupId>
+ <artifactId>commons-compiler</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.codehaus.janino</groupId>
+ <artifactId>janino</artifactId>
+ </dependency>
Review comment:
Remove them?? The orignal code is `dependencyManagement` which is different
from `dependencies`.
Btw, Janino is already depended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
