wuchong commented on a change in pull request #11340: [Flink 14338] Upgrade
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r393480377
##########
File path:
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java
##########
@@ -772,44 +800,50 @@ public void testCreateViewWithEmptyFields() {
@Test
public void testCreateFunction() {
- check("create function catalog1.db1.function1 as
'org.apache.fink.function.function1'",
- "CREATE FUNCTION `CATALOG1`.`DB1`.`FUNCTION1` AS
'org.apache.fink.function.function1'");
+ sql("create function catalog1.db1.function1 as
'org.apache.fink.function.function1'")
+ .ok("CREATE FUNCTION
`CATALOG1`.`DB1`.`FUNCTION1` AS 'org.apache.fink.function.function1'");
- check("create temporary function catalog1.db1.function1 as
'org.apache.fink.function.function1'",
- "CREATE TEMPORARY FUNCTION `CATALOG1`.`DB1`.`FUNCTION1`
AS 'org.apache.fink.function.function1'");
+ sql("create temporary function catalog1.db1.function1 as
'org.apache.fink.function.function1'")
+ .ok("CREATE TEMPORARY FUNCTION
`CATALOG1`.`DB1`.`FUNCTION1` AS 'org.apache.fink.function.function1'");
- check("create temporary system function catalog1.db1.function1
as 'org.apache.fink.function.function1'",
- "CREATE TEMPORARY SYSTEM FUNCTION
`CATALOG1`.`DB1`.`FUNCTION1` AS 'org.apache.fink.function.function1'");
+ sql("create temporary system function catalog1.db1.function1 as
'org.apache.fink.function.function1'")
+ .ok("CREATE TEMPORARY SYSTEM FUNCTION
`CATALOG1`.`DB1`.`FUNCTION1` AS 'org.apache.fink.function.function1'");
- check("create temporary function db1.function1 as
'org.apache.fink.function.function1'",
- "CREATE TEMPORARY FUNCTION `DB1`.`FUNCTION1` AS
'org.apache.fink.function.function1'");
+ sql("create temporary function db1.function1 as
'org.apache.fink.function.function1'")
+ .ok("CREATE TEMPORARY FUNCTION
`DB1`.`FUNCTION1` AS 'org.apache.fink.function.function1'");
- check("create temporary function function1 as
'org.apache.fink.function.function1'",
- "CREATE TEMPORARY FUNCTION `FUNCTION1` AS
'org.apache.fink.function.function1'");
+ sql("create temporary function function1 as
'org.apache.fink.function.function1'")
+ .ok("CREATE TEMPORARY FUNCTION `FUNCTION1` AS
'org.apache.fink.function.function1'");
- check("create temporary function if not exists
catalog1.db1.function1 as 'org.apache.fink.function.function1'",
- "CREATE TEMPORARY FUNCTION IF NOT EXISTS
`CATALOG1`.`DB1`.`FUNCTION1` AS 'org.apache.fink.function.function1'");
+ sql("create temporary function if not exists
catalog1.db1.function1 as 'org.apache.fink.function.function1'")
+ .ok("CREATE TEMPORARY FUNCTION IF NOT EXISTS
`CATALOG1`.`DB1`.`FUNCTION1` AS 'org.apache.fink.function.function1'");
- check("create temporary function function1 as
'org.apache.fink.function.function1' language java",
- "CREATE TEMPORARY FUNCTION `FUNCTION1` AS
'org.apache.fink.function.function1' LANGUAGE JAVA");
+ sql("create temporary function function1 as
'org.apache.fink.function.function1' language java")
+ .ok("CREATE TEMPORARY FUNCTION `FUNCTION1` AS
'org.apache.fink.function.function1' LANGUAGE JAVA");
- check("create temporary system function function1 as
'org.apache.fink.function.function1' language scala",
- "CREATE TEMPORARY SYSTEM FUNCTION `FUNCTION1` AS
'org.apache.fink.function.function1' LANGUAGE SCALA");
+ sql("create temporary system function function1 as
'org.apache.fink.function.function1' language scala")
+ .ok("CREATE TEMPORARY SYSTEM FUNCTION
`FUNCTION1` AS 'org.apache.fink.function.function1' LANGUAGE SCALA");
}
@Test
public void testDropTemporaryFunction() {
- check("drop temporary function catalog1.db1.function1",
- "DROP TEMPORARY FUNCTION `CATALOG1`.`DB1`.`FUNCTION1`");
+ sql("drop temporary function catalog1.db1.function1")
+ .ok("DROP TEMPORARY FUNCTION
`CATALOG1`.`DB1`.`FUNCTION1`");
- check("drop temporary system function catalog1.db1.function1",
- "DROP TEMPORARY SYSTEM FUNCTION
`CATALOG1`.`DB1`.`FUNCTION1`");
+ sql("drop temporary system function catalog1.db1.function1")
+ .ok("DROP TEMPORARY SYSTEM FUNCTION
`CATALOG1`.`DB1`.`FUNCTION1`");
- check("drop temporary function if exists
catalog1.db1.function1",
- "DROP TEMPORARY FUNCTION IF EXISTS
`CATALOG1`.`DB1`.`FUNCTION1`");
+ sql("drop temporary function if exists catalog1.db1.function1")
+ .ok("DROP TEMPORARY FUNCTION IF EXISTS
`CATALOG1`.`DB1`.`FUNCTION1`");
- check("drop temporary system function if exists
catalog1.db1.function1",
- "DROP TEMPORARY SYSTEM FUNCTION IF EXISTS
`CATALOG1`.`DB1`.`FUNCTION1`");
+ sql("drop temporary system function if exists
catalog1.db1.function1")
+ .ok("DROP TEMPORARY SYSTEM FUNCTION IF EXISTS
`CATALOG1`.`DB1`.`FUNCTION1`");
+ }
+
+ @Test
+ public void testTableHintsInInsert() {
Review comment:
Why do we have to have this emtpy test? The superclass doesn't have this
test too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
