xintongsong commented on a change in pull request #11445: [FLINK-16615] 
Introduce data structures and utilities to calculate Job Manager memory 
components
URL: https://github.com/apache/flink/pull/11445#discussion_r394809166
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorProcessUtils.java
 ##########
 @@ -48,23 +58,29 @@
 public class TaskExecutorProcessUtils {
        private static final Logger LOG = 
LoggerFactory.getLogger(TaskExecutorProcessUtils.class);
 
+       static final JvmMetaspaceAndOverheadOptions 
TM_JVM_METASPACE_AND_OVERHEAD_OPTIONS =
+               new JvmMetaspaceAndOverheadOptions(
+                       TaskManagerOptions.TOTAL_PROCESS_MEMORY,
+                       TaskManagerOptions.JVM_METASPACE,
+                       TaskManagerOptions.JVM_OVERHEAD_MIN,
+                       TaskManagerOptions.JVM_OVERHEAD_MAX,
+                       TaskManagerOptions.JVM_OVERHEAD_FRACTION
+               );
+
+       @SuppressWarnings("deprecation")
+       static final LegacyHeapOptions TM_LEGACY_HEAP_OPTIONS =
+               new LegacyHeapOptions(
+                       "FLINK_TM_HEAP",
+                       TaskManagerOptions.TASK_MANAGER_HEAP_MEMORY,
+                       TaskManagerOptions.TASK_MANAGER_HEAP_MEMORY_MB
+               );
+
        private TaskExecutorProcessUtils() {}
 
        // 
------------------------------------------------------------------------
        //  Generating JVM Parameters
        // 
------------------------------------------------------------------------
 
 Review comment:
   This comment can also be removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to