xintongsong commented on a change in pull request #11445: [FLINK-16615]
Introduce data structures and utilities to calculate Job Manager memory
components
URL: https://github.com/apache/flink/pull/11445#discussion_r394777251
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
##########
@@ -82,9 +84,10 @@
* JVM heap size for the JobManager with memory size.
*/
@Documentation.Section(Documentation.Sections.ALL_JOB_MANAGER)
- public static final ConfigOption<String> JOB_MANAGER_HEAP_MEMORY =
+ public static final ConfigOption<MemorySize> JOB_MANAGER_HEAP_MEMORY =
key("jobmanager.heap.size")
- .defaultValue("1024m")
+ .memoryType()
+ .defaultValue(MemorySize.ofMebiBytes(1024))
Review comment:
This seems less related. Might be better to put in a separate hotfix commit.
Same for the generated html and codes accessing this option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
