xintongsong commented on a change in pull request #11445: [FLINK-16615]
Introduce data structures and utilities to calculate Job Manager memory
components
URL: https://github.com/apache/flink/pull/11445#discussion_r394807903
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorProcessSpec.java
##########
@@ -159,10 +159,12 @@ public MemorySize getTotalProcessMemorySize() {
return
getTotalFlinkMemorySize().add(jvmMetaspaceSize).add(jvmOverheadSize);
}
+ @Override
Review comment:
We should also add the override annotation for the other 4 methods:
- getTotalProcessMemorySize
- getTotalFlinkMemorySize
- getJvmOverheadSize
- getJvmMetaspaceSize
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
